Skip to content

test: Correct the server and client certificates used in dialer_test.go#933

Merged
hessjcg merged 1 commit intomainfrom
gh-932-test-certs
Feb 5, 2025
Merged

test: Correct the server and client certificates used in dialer_test.go#933
hessjcg merged 1 commit intomainfrom
gh-932-test-certs

Conversation

@hessjcg
Copy link
Collaborator

@hessjcg hessjcg commented Jan 31, 2025

Update the dialer_test and other tests to use more accurate certificate validation logic. This improves the tests in these ways:

  1. The tests now do full mTLS verification.
  2. The certificates used in the tests accurately reproduce the structure of the real certificates used by Cloud SQL
  3. The complex certificate logic is now consolidated into internal/mock/certs.go

Part of #932

@hessjcg hessjcg force-pushed the gh-932-test-certs branch 4 times, most recently from 3a7c320 to d237673 Compare January 31, 2025 22:39
@hessjcg hessjcg marked this pull request as ready for review January 31, 2025 22:40
@hessjcg hessjcg requested a review from a team as a code owner January 31, 2025 22:40
jackwotherspoon
jackwotherspoon approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple nits, otherwise LGTM ✅

@hessjcg hessjcg merged commit ae376f1 into main Feb 5, 2025
14 checks passed
@hessjcg hessjcg deleted the gh-932-test-certs branch February 5, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackwotherspoon jackwotherspoon jackwotherspoon approved these changes

Assignees

@jackwotherspoon jackwotherspoon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hessjcg @jackwotherspoon